Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nx-dev): load external script dynamically on route changes #29355

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bcabanes
Copy link
Member

Moved the external script loading logic to a dynamic handler triggered on route changes using useEffect. This ensures the script is reloaded with each route change and prevents duplicates by removing any pre-existing script.

Moved the external script loading logic to a dynamic handler triggered on route changes using `useEffect`. This ensures the script is reloaded with each route change and prevents duplicates by removing any pre-existing script.
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 13, 2024 7:32pm

Copy link

nx-cloud bot commented Dec 13, 2024

Your CI Pipeline Execution ↗ for commit b5fe2c9 ⏳ is in progress.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 5m, 50s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 13s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 0s View ↗
nx-cloud record -- nx format:check --base=0f9c9... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 0s View ↗
nx documentation --no-dte ✅ Succeeded 0s View ↗

Last updated at 2024-12-13 19:32:11UTC

Sent with 💌 from NxCloud.

@bcabanes bcabanes marked this pull request as ready for review December 13, 2024 19:23
@bcabanes bcabanes requested a review from a team as a code owner December 13, 2024 19:23
@bcabanes bcabanes requested a review from isaacplmann December 13, 2024 19:23
@bcabanes bcabanes merged commit 4cd640a into master Dec 13, 2024
6 checks passed
@bcabanes bcabanes deleted the docs/nx-dev/update-rr2b-script-integration branch December 13, 2024 19:32
bcabanes added a commit that referenced this pull request Dec 13, 2024
Moved the external script loading logic to a dynamic handler triggered
on route changes using `useEffect`. This ensures the script is reloaded
with each route change and prevents duplicates by removing any
pre-existing script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants